chore: remove unused lightningdevkit and sqlite deps #322
+9
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-kaufman
force-pushed
the
chore/remove-unused-dependencies
branch
from
786409f to
f177b0e
Compare
ovitrif
reviewed
Jan 13, 2026
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
utAck
testing next ♻️ …
ovitrif
approved these changes
Jan 13, 2026
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Tested with same flow as android, using regtest RN → regtest iOS
1. Migration from RN 🟢
- Install RN Bitkit and setup with a funded wallet
- Do a Transfer to Spending to have at least one channel
- Uninstall RN app (go to Settings → Back up or Restore → Check that everything is green)
- Install this build over RN app
- Verify migration completes successfully & LN channel(s) are still open
- Do a send and a receive over LN to confirm LN node is alive and working
Collaborator
|
Not sure why e2e didn't run, I guess because PR was first draft then non-draft but no push afterwards 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes LDK and SQLite dependencies