Simplify Proposal Creation and Sending Process #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Step 5 combined both go_prepare and go_submit operations in a single step, which was confusing to users. This change separates them into: - Step 5: Prepare proposal (go_prepare command + payment txId entry) - Step 6: Submit proposal (go_submit command + proposal hash entry) Changes: - Split Step 5 into two separate wizard steps - Removed unused collapse state management - Updated navigation logic to properly advance between steps - Modified useProposalSubmission hook to use callback for step advancement - Updated recovery flow to handle saved proposals correctly This makes the proposal creation process clearer and easier to understand. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Created two new components to reduce bloat in ProposalForm.jsx: - PrepareProposal.jsx: Handles Step 5 (go_prepare command and payment txId) - SubmitProposal.jsx: Handles Step 6 (go_submit command and proposal hash) Changes: - Extracted Step 5 logic into PrepareProposal component - Extracted Step 6 logic into SubmitProposal component - Moved validation schemas to individual components - Removed unused imports from ProposalForm.jsx - Reduced ProposalForm.jsx from ~490 lines to ~390 lines - Improved code maintainability and reusability Benefits: - Cleaner, more modular code structure - Each component now has a single responsibility - Easier to test and maintain individual steps - Better separation of concerns 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Failed to generate code suggestions for PR |
- Fix yup validation to handle null/undefined values - Use consistent quote style (single quotes) for imports - Fix useCallback dependency issue in ProposalForm - Add semicolons for consistency Changes: - PrepareProposal.jsx: Update quotes and add null check in yup validator - SubmitProposal.jsx: Update quotes and add null check in yup validator - ProposalForm.jsx: Fix useCallback to use functional setState 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.