Misc cleanups #48
Merged
Misc cleanups #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Fixes: ef237e7 ("Remove debug logging") Signed-off-by: Tim Crawford <tcrawford@system76.com>
- Move default target and rustflags to `.cargo/config.toml` - Remove use of mtools/parted and use target directory as a drive - Remove `startup.nsh` script and document how to load the driver in QEMU - Remove `deps.sh` now that Make and Rust are the only dependencies - Replace use of `emit` with specifying the normal binary path Signed-off-by: Tim Crawford <tcrawford@system76.com>
leviport
approved these changes
Dec 3, 2024
Member
leviport
left a comment
leviport
left a comment
There was a problem hiding this comment.
Tested on oryp12. Firmware-setup seems to be working fine with these changes.
jackpot51
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply some cleanups for commit ef237e7 specifically:
debugfeaturecorebootmoduleAnd some more generally
.cargo/config.tomlstartup.nshscript and document how to load the driver in QEMUdeps.shnow that Make and Rust are the only dependenciesemitwith specifying the normal binary path