✨ Add Offline Mode #694
Open
✨ Add Offline Mode #694
+8,429
−5,153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doobry-systemli
left a comment
doobry-systemli
left a comment
There was a problem hiding this comment.
Really nice, thanks for tackling this! I made some comments, mostly nitpicking.
src/components/OfflineWarning.tsx
Outdated
| d="M18.364 5.636a9 9 0 010 12.728M5.636 5.636a9 9 0 000 12.728M12 12h.01M8.464 8.464a5 5 0 017.072 7.072M8.464 15.536a5 5 0 010-7.072" | ||
| /> | ||
| </svg> | ||
| <p>You appear to be offline. Some content may be outdated.</p> |
Contributor
There was a problem hiding this comment.
Nitpicking, but this could be shortened: "Offline, content may be outdated."
0x46616c6b
force-pushed
the
Add-Offline-Mode
branch
from
4700625 to
1a80442
Compare
doobry-systemli
approved these changes
Jan 6, 2026
Contributor
doobry-systemli
left a comment
doobry-systemli
left a comment
There was a problem hiding this comment.
I did some local testing and it seems to work well.
- The offline indicator message shows immediately when going offline and hides when going back online.
- After opening the ticker once in the browser, I can close the browser and open it again while being offline and the ticker page loads from cache.
- When scrolling to the bottom and then going back online, additional messages load immediately.
- When new messages are added to the ticker while the browser is offline, they load immediately after going back online.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds offline support and persistent caching to the application, improving the user experience when the network is unavailable. It introduces a service worker for asset and API caching, uses React Query's persistence features to store data in localStorage, and provides a user-visible offline warning. Additionally, it updates the application's logic to better detect and handle offline states.
How to test?
npm run buildnpm run preview