Add optional note to alias #872
Open
+164
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2d
force-pushed
the
alias-note
branch
2 times, most recently
from
6494877 to
ce7c663
Compare
|
t2d
requested review from
0x46616c6b,
doobry-systemli and
y3n4
as code owners
0x46616c6b
requested changes
Sep 6, 2025
src/Entity/Alias.php
Outdated
| protected ?string $destination = null; | ||
|
|
||
| #[ORM\Column(length: 255, nullable: true)] | ||
| #[Assert\Length(max: 255)] |
Member
There was a problem hiding this comment.
For whatever reason, we used to do validation directly in the entity. But that's not the typical approach. Form models are designed for that. While this is already incorrect in the existing code, it should be adjusted.
Member
There was a problem hiding this comment.
And I would reduce the validation to 30-50 characters, otherwise we'll have to make adjustments to the design to accommodate a possible 255 characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional note to random aliases during creation to help memorize their purpose
