Skip to content

Conversation

@talltechy
Copy link
Owner

@talltechy talltechy commented Oct 13, 2025

This PR updates GitHub Copilot instructions and related documentation to improve secrets handling and developer guidance.\n\nSummary:\n- Removed hardcoded environment examples from Copilot instructions and added secure guidance for environment variables and secret managers.\n- Added a short Secrets Policy and PR/commit checklist for contributors.\n- Added guidance about Copilot usage (never generate code with embedded credentials).\n- Updated README and MIGRATION.md to reference the new Copilot instructions.\n\nChecklist:\n- [x] No secrets or hardcoded credentials are introduced in this diff\n- [x] Code formatting and static checks suggested (black, flake8, mypy)\n- [x] README and MIGRATION.md updated to reference Copilot guidance\n- [ ] Tests added/updated where applicable (use mocks/fixtures for API calls)\n- [x] Documentation and migration notes updated for any public API or behavior changes\n- [x] Security note added (recommend follow-up pre-commit/secret-scan PR)\n\nRequested reviewers: @mattwyen — please add other maintainers as needed for security review.

Copilot AI review requested due to automatic review settings October 13, 2025 21:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the GitHub Copilot instructions with comprehensive security and development best practices. The update transforms the documentation from containing hardcoded credential examples to providing secure configuration guidance with proper secrets management.

Key changes include:

  • Removal of hardcoded credential examples and addition of comprehensive secrets policy
  • Introduction of PR/commit checklist and security guidelines for development workflow
  • Addition of API naming compatibility guidance to prevent inheritance conflicts

@codacy-production
Copy link

codacy-production bot commented Oct 13, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3dbcc81) 1204 414 34.39%
Head commit (639217f) 1204 (+0) 414 (+0) 34.39% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#102) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@talltechy talltechy merged commit 705156f into main Oct 13, 2025
19 of 20 checks passed
@talltechy talltechy deleted the docs/update-copilot-instructions-secrets-policy branch October 13, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants