-
Notifications
You must be signed in to change notification settings - Fork 1
✨ Set up comprehensive GitHub Copilot instructions #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Co-authored-by: talltechy <43618761+talltechy@users.noreply.github.com>
Co-authored-by: talltechy <43618761+talltechy@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements comprehensive GitHub Copilot instructions to enhance code generation capabilities for the InsightVM-Python repository. The instructions provide detailed guidance on architecture patterns, coding standards, and development workflows to ensure consistent, high-quality code generation.
- Added a 486-line comprehensive guide in
.github/copilot-instructions.md - Documented BaseAPI inheritance pattern, unified client interface, and project structure
- Established coding standards with PEP 8, type hints, and Google-style docstrings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ### Error Handling | ||
|
|
||
| Use appropriate exception handling: |
Copilot
AI
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception handling order should be from most specific to most general. requests.exceptions.RequestException is a base class and should be caught last, but TimeoutError is more general than ValueError. Consider reordering or using more specific exception types.
| class InsightVMClient: | ||
| def __init__(self, ...): | ||
| # ... existing code ... | ||
| self.examples = ExampleAPI(self.auth, verify_ssl, timeout) |
Copilot
AI
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter order in the ExampleAPI constructor should be consistent with other API classes. Based on the BaseAPI pattern, it should likely be ExampleAPI(self.auth, self.base_url, verify_ssl, timeout) to include the base_url parameter.
| self.examples = ExampleAPI(self.auth, verify_ssl, timeout) | |
| self.examples = ExampleAPI(self.auth, self.base_url, verify_ssl, timeout) |
Overview
Implements comprehensive GitHub Copilot instructions for the InsightVM-Python repository as documented in GitHub's best practices for Copilot coding agent.
What's New
Created
.github/copilot-instructions.md- a 486-line comprehensive guide that provides GitHub Copilot with detailed context about the repository's architecture, coding standards, testing requirements, and development workflows.Key Sections Covered
Project Architecture
BaseAPIDevelopment Standards
Practical Guides
CI/CD Context
Benefits
With these instructions in place, GitHub Copilot will:
Testing
File Details
.github/copilot-instructions.mdThis enhancement complements the existing
.github/instructions/codacy.instructions.mdfile, which focuses on Codacy-specific MCP Server integration, while the new Copilot instructions provide general repository guidance.Closes #[issue number]
Original prompt
Fixes #97
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.