Skip to content

[DO NOT MERGE] error-boundary example #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
taneba wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] error-boundary example #336

taneba wants to merge 6 commits into from

Conversation

@taneba
Copy link
Owner

@taneba taneba commented Apr 6, 2022 •
edited
Loading

This is an implementation example of ErrorBoundary with Suspense.
IMO using ErrorBoundary with Suspense doesn't make sense because

  • Component inside of the ErrorBoundary and Suspense should know the parent component's implementation, which is really bad design.
  • During development, we'll see a lot of red errors on the browser or console, which is not good DX.

related #334

Base automatically changed from core/react-18 to main May 12, 2022 17:17
@taneba taneba added the pending label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taneba