-
-
Notifications
You must be signed in to change notification settings - Fork 106
fix(cardmarket): update idReference for Scarlet & Violet #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cardmarket): update idReference for Scarlet & Violet #1049
Conversation
🃏 86 Cards ChangedDetails: 86 modified Tarountula (sv01-017) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/017.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/017.ts) Tarountula (sv01-018) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/018.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/018.ts) Smoliv (sv01-021) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/021.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/021.ts) Toedscool (sv01-025) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/025.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/025.ts) Capsakid (sv01-028) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/028.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/028.ts) Growlithe (sv01-031) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/031.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/031.ts) Charcadet (sv01-040) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/040.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/040.ts) Wiglett (sv01-056) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/056.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/056.ts) Cetoddle (sv01-059) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/059.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/059.ts) Rotom (sv01-070) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/070.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/070.ts) Pawmi (sv01-074) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/074.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/074.ts) Wattrel (sv01-078) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/078.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/078.ts) Miraidon (sv01-080) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/080.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/080.ts) Dedenne (sv01-095) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/095.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/095.ts) Fidough (sv01-098) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/098.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/098.ts) Flittle (sv01-101) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/101.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/101.ts) Flittle (sv01-102) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/102.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/102.ts) Greavard (sv01-104) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/104.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/104.ts) Greavard (sv01-105) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/105.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/105.ts) Riolu (sv01-113) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/113.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/113.ts) Koraidon (sv01-124) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/124.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/124.ts) Maschiff (sv01-136) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/136.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/136.ts) Varoom (sv01-141) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/141.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/141.ts) Zangoose (sv01-147) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/147.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/147.ts) Lechonk (sv01-154) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/154.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/154.ts) Tandemaus (sv01-160) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/160.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/160.ts) Cyclizar (sv01-164) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/164.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/164.ts) Professor's Research (sv01-190) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/190.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/190.ts) Tarountula (sv01-199) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/199.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/199.ts) Dolliv (sv01-200) (found using en)File: [data/Scarlet & Violet/Scarlet & Violet/200.ts](https://github.com/tcgdex/cards-database/blob/c500dc394837e7e3e8c0c3b96a0c68d591ad57d6/data/Scarlet & Violet/Scarlet & Violet/200.ts)
|
|
how did you validate the id on cardmarket. Example: |
|
This type of link ( Therefore, you need to go to a card's page (example: https://www.cardmarket.com/en/Pokemon/Products/Singles/Scarlet-Violet/Gogoat-SVI012?language=2), and on the "Contact Support" link, you'll find the ID reference in the URL: https://support.cardmarket.com/en/support/tickets/new?category=Catalogue%20details%20and%20inventory%20queries&idReference=702309 I was able to do quite a few tests with other cards, for example, from the "Phantasmal Flames" series, which match the value on both sides. Seeing that the API card prices didn't match the actual Cardmarket prices, I looked into the problem, and that's it. However, you have to check the cards one by one... That's great! |
|
The GraphQL error 'Cannot return null for non-nullable field Set.serie' appears to be unrelated to the cardmarket ID changes in this PR. The PR only modifies values in card files and doesn't touch any Set or Serie definitions. This error typically indicates a data integrity issue where a Set object is missing its serie reference. Since the PR changes don't affect Set definitions, this might be:
Could you try re-running the failed test workflows to see if the error persists? |
This comment was marked as outdated.
This comment was marked as outdated.
|
@Chester-ttv your changes seems good to me ! whenever you seem ready, Mark it as ready & it will be merged after that ! |








































































































































































































































































































































































Changes
thirdParty.cardmarketvalues for the Scarlet & Violet setDetails
Your feedback is welcome so I can continue with the other sets 🙂