Added Unlock feature #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a dynamic dropdown; Moved vote option creation to PollHelpers Prevent button press processing when vote is locked; Changed how "isLocked" status is determined; Add notification to user if their vote was blocked due to it being locked. Remove empty votes from results; Remove null from section, because null causes errors when sending the message.
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| private onUnlockSelected(payload: any, poll: Poll): void { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| this.isLocked = true; | ||
| this.generateVoteResults(); | ||
| this.message = this.message.slice(0, 2).concat(this.message.slice(this.getDividerId() - 1)); | ||
| this.message = this.message.slice(0, this.getDividerId() - 1).concat(this.getDynamicSelect()).concat(this.message.slice(this.getDividerId())); |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
|
||
| public unlockpoll(): void { | ||
| this.isLocked = false; | ||
| this.message = this.message.slice(0, this.getDividerId() - 1).concat(this.getDynamicSelect()).concat({type: "divider"}).concat(this.message.slice(this.getDividerId() + 2)); |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit b28ae50 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Unlock feature;
Made a dynamic dropdown;
Moved vote option creation to PollHelpers
Prevent button press processing when vote is locked;
Changed how "isLocked" status is determined;
Add notification to user if their vote was blocked due to it being locked.
Remove empty votes from results;
Remove null from section, because null causes errors when sending the message;
Ran ESlint;