Skip to content

Conversation

@lukaszachy
Copy link
Contributor

@lukaszachy lukaszachy commented Feb 18, 2025

Especially from 'tmt' we want to adjust just tests and keep other types of nodes intact (plan, story).

Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • mention the version
  • include a release note

@lukaszachy lukaszachy added this to the 1.7 milestone Feb 18, 2025
@lukaszachy lukaszachy requested a review from happz February 19, 2025 10:12
Especially from 'tmt' we want to adjust just tests and keep other types
of nodes intact (plan, story).
@lukaszachy lukaszachy force-pushed the lzachar-adjust-filternodes branch from 545d2e2 to a341840 Compare February 27, 2025 17:10
Copy link
Contributor

@therazix therazix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor docstring suggestion.

@psss psss added the base label Mar 7, 2025
Copy link
Contributor

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for implementing this.

@psss psss self-assigned this Mar 7, 2025
@psss
Copy link
Contributor

psss commented Mar 7, 2025

Failures on centos-stream-10 are expected (no tmt yet) and fedora-42 as well (old tmt version).

@psss psss merged commit 0b137db into main Mar 7, 2025
13 of 15 checks passed
@psss psss deleted the lzachar-adjust-filternodes branch March 7, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants