You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still a lot to be done and this is a draft PR not meant to be merged in (at least not yet). It's my exploration integrating the Wharf Session Kit into OBE and replacing all of the UAL code/hacks OBE currently depends on.
I have a lot of comments about how OBE could be simplified and how the user interaction flow could be modified - but need to find the time to write all that up. I'm putting this up as a draft pull request just for visibility and discussion 👍
Also just to note I haven't implemented any "real" wallet plugins, so this is only really working well with the Jungle 4 configuration. As soon as the Anchor wallet plugin is ready (we're still fixing bugs), I'll get that added in and it should work with all networks.
The MockWalletPlugin is set now to use whatever network you're on, and simulate a login to the eosio@active account for testing purposes. Every transaction you try to perform is going to fail (for obvious reasons), but it'll at least allow interaction with the login/logout/restore/transact flows.
I've added the Anchor and cleos wallet plugins now, I think it's mostly functional. Still cleanup to do on our end as well as in the OBE to remove all the other cleos presentation stuff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's still a lot to be done and this is a draft PR not meant to be merged in (at least not yet). It's my exploration integrating the Wharf Session Kit into OBE and replacing all of the UAL code/hacks OBE currently depends on.
I have a lot of comments about how OBE could be simplified and how the user interaction flow could be modified - but need to find the time to write all that up. I'm putting this up as a draft pull request just for visibility and discussion 👍