Support scala 2.12.10 and spark 2.4.4 #155
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
| } | ||
|
|
||
| object DefaultSource { | ||
| object DefaultSource extends scala.Serializable { |
There was a problem hiding this comment.
| dir.mkdirs() | ||
| // The path to the partition file. | ||
| val filePath = localPath + s"/part-" + String.format("%05d", new java.lang.Integer(index)) | ||
| val filePath = localPath + s"/part-" + String.format("%05d", java.lang.Integer.valueOf(index)) |
There was a problem hiding this comment.
Constructor of Integer is deprecated, with -Xfatal-warnings the build fails.
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@skavulya Mind taking a look? |
|
I would really like a Scala 2.12 version to be published as well. |
|
@vikatskhay Thanks for the contribution. It looks good. |
|
Thanks heaps for reviewing this PR. What should be my next steps to get it merged? |
|
Quick question: when could the new version be released including this change? |
|
maven central gets updated whenever a new TensorFlow version is released |
Hmmm... is there a technical reason for this? It doesn't seem to be the case though, since there have been numerous TensorFlow releases since Aug 2018, but Maven central is showing that the last time this connector was released was in Aug 2018. https://mvnrepository.com/artifact/org.tensorflow/spark-connector_2.11/1.10.0 |
|
The connector is https://mvnrepository.com/artifact/org.tensorflow/spark-tensorflow-connector There is no update since TensorFlow 2.0 @jhseu What would we need to do to update the release scripts? |
|
It seems this did not get updated with TF 2.2. |
|
Would be so great to get this out on maven central. |
6 participants
Hello.
Related to #141 (comment)
Not sure whether it'd be better to support multiple scala versions, perhaps introducing multiple profiles could be a good idea. As I understood from the comments #141 scala 2.11 could be left behind. Please let me know if I understood it incorrectly.
Tested with: