Fix pagination issue in customer search #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controller/CustomerController.php
Outdated
|
|
||
| return $this->render('customers'); | ||
| $data = $baseForm->getForm()->getData(); | ||
| $choice = ""; |
Contributor
There was a problem hiding this comment.
Simples quotes pour les strings si pas besoin d'interpréter des variables
Controller/CustomerController.php
Outdated
| && $choice == 'all' | ||
| ) { | ||
| return $this->generateRedirectFromRoute('admin.customers'); | ||
| } elseif ($data['company'] === null |
Contributor
There was a problem hiding this comment.
Tu peux refacto ces 2 parties en faisant par exemple && in_array($choice, ['', 'all']
mabruchet
force-pushed
the
fix/pagination_redirection_to_customers
branch
from
2434ee8 to
516fb1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pagination issue with a generateRedirectFromRoute which it redirect to the customers page when any filter is use.