-
Notifications
You must be signed in to change notification settings - Fork 112
Permanently unload device #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It's not yet tested. It just marks tables as "wasUnloaded". @Phil1pp could you test it? |
|
The timeout and the write is working, however it keeps triggering the write every 5000ms. |
|
I resetted the flag WasUnloaded. |
|
It looks good now. Thanks a lot. |
|
Thanks for your testing. @thelsing what do you think about the solution? |
|
My first idea would be to add the timeout to the Memory class instead. So on "ClearMemory" one would set a timeout and do a writeMemory after it's reached. This seems to be a bit more centralized if we clear memory for some other reason. Does this seam reasonable? |
|
This would also be a good idea. I also added a reset of the timeout if there is write access to the memory. This will prevent write memory while the ets wants to load the application into the device (since it unloads every table before). |
|
After you last change it doesn't work anymore because _saveTimeout is never set. You probably still have to check if TableObject state changed to LS_UNLOADED. |
|
Okay, i now moved it to freeMemory(). |
|
I tested it again and it's working fine now. |
|
It's a bit less obvious how this works than I'd like it to be, but it's good enough to merge. |
Permanently unload device
Remove `clearMemory();` in Header as Result of Cherry-Pick
…nloding-fix Fix for PR #316: Special Case Handling for Unload-Timeout
First attempt to fix permanently unloading a device according to thelsing/knx #144