Skip to content

Conversation

@themuffinator
Copy link
Owner

Motivation

  • Preserve diagnostic parity with the original HLIL by emitting startup banners and guard/rejection messages via the engine Print callback.
  • Reconstruct the HLIL-observed initialization order so subsystems acquire dependencies deterministically.
  • Prevent partial subsystem startup by short-circuiting when allocator/import bootstrap fails (so no other subsystems run after memory or import failures).
  • Conform to repository conventions by adding commented function headers and normalising indentation in the interface implementation.

Description

  • Moved the historical startup banners and guard diagnostics into the core BotSetupLibrary and emit them through BotLib_Print (the Print callback), including explicit invalid-import and memory-failure messages.
  • Reordered initialization to follow the HLIL-documented sequence: Botlib_SetupUtilities, Botlib_SetupAISubsystem, Botlib_SetupEASubsystem, Botlib_SetupAASSubsystem, then Botlib_SetupSoundSubsystem, and added appropriate unwind/shutdown paths on failure.
  • Short-circuited on BotMemory_Init/import validation failures so other subsystems are not initialised when these fail.
  • Added commented headers above functions and normalised indentation (tabs) in src/botlib/interface/botlib_interface.c, and simplified the wrapper BotSetupLibraryWrapper to delegate to the core BotSetupLibrary.

Testing

  • Cross-checked diagnostic strings and severities against tests/reference/botlib_contract.json and the parity guidance in tests/parity/README.md for message/text consistency.
  • No automated unit tests or parity test-suite runs were executed as part of this change.
  • Local repository static edits (headers/indent) and build-related housekeeping only; no runtime regressions were exercised automatically.

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants