-
Notifications
You must be signed in to change notification settings - Fork 19
Hdf5 versions support and refactoring promolecule #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
enjyashraf18
wants to merge
15
commits into
theochem:dev-gsoc
Choose a base branch
from
enjyashraf18:hdf5-versions-support
base: dev-gsoc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hdf5 versions support and refactoring promolecule #161
enjyashraf18
wants to merge
15
commits into
theochem:dev-gsoc
from
enjyashraf18:hdf5-versions-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Updated run module for numeric dataset 2. Created customized HDF5 file creator for numeric 3. Migrated all old files from msgpack to HDF5 #handle wildcard case while loading the element
1. Updated run module for nist dataset 2. Created customized HDF5 file creator for nist 3. Migrated all old files from msgpack to HDF5
- Versioned file naming: datasets_data-v{version:03d}.h5 pattern (v000, v001, etc.)
- Kept the latest version HDF5 file open by default.
- Opens/closes specific version files only when explicitly requested.
1. test_api: skip when dataset is numeric, since numeric datasets do not support orbital gradients 2. gaussian: updated grid.shape to 1000 3. test_nist: treat None and NaN as equivalent for the energy field, as empty values in the HDF5 file are assigned NaN 4. test_wfn_slater: treat None and NaN as equivalent for the mu and eta fields
- Updated `load`, `compile_species`, and `datafile` to work with the new global database structure. - Each dataset has its own HDF5 file. - Enables more efficient memory usage by avoiding loading all datasets into one monolithic file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.