dp: nocodec: switch playback SRC to DP by default #10469
+27
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@lyakh Some nocodec failings. |
Collaborator
Author
@lgirdwood yes, I've traced it back to an update in Zephyr, which had disabled double mapping. I'm working to fix it. |
Since Zephyr has removed double mapping per Kconfig switch we need to restore it in SOF. Next we should try to optimize mappings to only use the ones we really need. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Switch one of the two SRC instances in the nocodec topology to DP mode by default. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
LaurentiuM1234,
dbaluta,
jsarha,
marcinszkudlinski,
pblaszko and
ranj063
as code owners
There was a problem hiding this comment.
Pull request overview
This PR switches the playback SRC (Sample Rate Converter) to use the DP (Data Processing) domain by default in the nocodec topology, while keeping the capture SRC in the default domain. Additionally, it adds cached memory partition support for DP scheduler tasks.
Key changes:
- Splits the SRC domain configuration into separate playback and capture domains
- Adds cached memory partition support (HEAP_CACHE and CFG_CACHE) for improved memory access patterns
- Updates test topology parameters to maintain capture path DP testing
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/topology/topology2/cavs-nocodec.conf | Splits SRC_DOMAIN into SRC_DOMAIN_PLAYBACK (DP) and SRC_DOMAIN_CAPTURE (default) and updates widget configurations |
| tools/topology/topology2/development/tplg-targets.cmake | Updates test topology parameters from SRC_DOMAIN to SRC_DOMAIN_CAPTURE for MTL, LNL, and PTL platforms |
| src/schedule/zephyr_dp_schedule_application.c | Adds cached memory partition initialization and cleanup for both heap and mailbox partitions |
| src/schedule/zephyr_dp_schedule.h | Extends the sof_dp_part_type enum with HEAP_CACHE and CFG_CACHE partition types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch one of the two SRC instances in the nocodec topology to DP mode by default.