Skip to content

Conversation

@Yash094
Copy link
Member

@Yash094 Yash094 commented Dec 24, 2025

[Playground] Fix: Exclude deprecated chains from x402 network selector

Notes for the reviewer

This change enables the existing disableDeprecated functionality of the SingleNetworkSelector component on the x402 playground page. This ensures that deprecated chains are no longer displayed in the network selection dropdown, consistent with patterns used elsewhere in the codebase.

How to test

  1. Navigate to https://playground.thirdweb.com/x402.
  2. Open the network selector dropdown.
  3. Verify that deprecated chains (e.g., Mumbai) are not listed.

Slack Thread

Open in Cursor Open in Web


PR-Codex overview

This PR introduces a new prop to a component, enhancing its functionality by disabling deprecated features.

Detailed summary

  • In the X402LeftSection.tsx file, a new prop disableDeprecated is added to an element, likely to prevent the use of outdated functionalities.
  • The placeholder remains "Select a chain" and the class name is still set to "bg-card".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Disabled a deprecated option in the network selector UI so the outdated choice no longer appears; this clarifies available network options and reduces confusion for users.

✏️ Tip: You can customize this high-level summary in your review settings.

@cursor
Copy link

cursor bot commented Dec 24, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@changeset-bot
Copy link

changeset-bot bot commented Dec 24, 2025

⚠️ No Changeset found

Latest commit: ec73f1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
thirdweb_playground Ready Ready Preview, Comment Dec 25, 2025 10:27am
4 Skipped Deployments
Project Deployment Review Updated (UTC)
docs-v2 Skipped Skipped Dec 25, 2025 10:27am
nebula Skipped Skipped Dec 25, 2025 10:27am
thirdweb-www Skipped Skipped Dec 25, 2025 10:27am
wallet-ui Skipped Skipped Dec 25, 2025 10:27am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025

Walkthrough

A disableDeprecated prop was added to the SingleNetworkSelector component usage in X402LeftSection.tsx without changes to control flow, state management, or public APIs.

Changes

Cohort / File(s) Summary
X402 Component Enhancement
apps/playground-web/src/app/x402/components/X402LeftSection.tsx
Added disableDeprecated prop to SingleNetworkSelector component instance

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title is vague and does not clearly convey the primary change. 'X402 playground chainlist' lacks specificity about what was modified (e.g., that deprecated chains are being excluded). Consider revising the title to be more descriptive, such as 'Exclude deprecated chains from X402 network selector' to better reflect the actual change.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description follows the required template with all essential sections: a clear title, notes for the reviewer explaining the change, and testing instructions. It provides context and clarity.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/x402-playground-chainlist-0d66

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7e530fb and ec73f1f.

📒 Files selected for processing (1)
  • apps/playground-web/src/app/x402/components/X402LeftSection.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/playground-web/src/app/x402/components/X402LeftSection.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Size
  • GitHub Check: Analyze (javascript)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.19%. Comparing base (245e9a6) to head (ec73f1f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8588   +/-   ##
=======================================
  Coverage   53.19%   53.19%           
=======================================
  Files         922      922           
  Lines       61480    61480           
  Branches     4032     4032           
=======================================
  Hits        32706    32706           
  Misses      28676    28676           
  Partials       98       98           
Flag Coverage Δ
packages 53.19% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@Yash094 Yash094 marked this pull request as ready for review December 24, 2025 15:33
@Yash094 Yash094 requested review from a team as code owners December 24, 2025 15:33
@Yash094 Yash094 added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 25, 2025
Copy link
Member Author

Yash094 commented Dec 25, 2025

Merge activity

## [Playground] Fix: Exclude deprecated chains from x402 network selector

## Notes for the reviewer

This change enables the existing `disableDeprecated` functionality of the `SingleNetworkSelector` component on the x402 playground page. This ensures that deprecated chains are no longer displayed in the network selection dropdown, consistent with patterns used elsewhere in the codebase.

## How to test

1.  Navigate to `https://playground.thirdweb.com/x402`.
2.  Open the network selector dropdown.
3.  Verify that deprecated chains (e.g., Mumbai) are not listed.

---
[Slack Thread](https://thirdwebdev.slack.com/archives/C09DS2CKGP2/p1766589810150189?thread_ts=1766589810.150189&cid=C09DS2CKGP2)

<a href="https://cursor.com/background-agent?bcId=bc-662b659b-43e5-4760-8634-cf73b25f1a02"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-662b659b-43e5-4760-8634-cf73b25f1a02"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a>

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new property to a component, enhancing its functionality by allowing it to disable deprecated features.

### Detailed summary
- Added the `disableDeprecated` property to the `X402LeftSection` component.
- This change modifies the component's behavior, likely affecting how deprecated features are handled.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **Bug Fixes**
  * Updated component configuration to disable deprecated options in the network selector.

<sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the cursor/x402-playground-chainlist-0d66 branch from 7e530fb to ec73f1f Compare December 25, 2025 10:26
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 25, 2025 10:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 25, 2025 10:26 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula December 25, 2025 10:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 25, 2025 10:26 Inactive
@graphite-app graphite-app bot merged commit ec73f1f into main Dec 25, 2025
25 checks passed
@graphite-app graphite-app bot deleted the cursor/x402-playground-chainlist-0d66 branch December 25, 2025 10:30
@vercel vercel bot temporarily deployed to Production – docs-v2 December 25, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Production – nebula December 25, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 25, 2025 10:30 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www December 25, 2025 10:30 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants