Skip to content

disable cleanup functions from networkd module #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashraffouda merged 2 commits into from
Dec 8, 2025
Merged

disable cleanup functions from networkd module #2652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceea9cd
Remove unused cleanup functions from networkd module, indicating futu…
Omarabdul3ziz Dec 8, 2025
9eed6ec
Update QEMU Makefile to allocate 8GB of memory for node-01 during exe…
Omarabdul3ziz Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cmds/modules/networkd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,12 @@ func action(cli *cli.Context) error {
return errors.Wrap(err, "failed to migrate older dhcp service")
}

if err := network.CleanupUnusedLinks(); err != nil {
return errors.Wrap(err, "failed to cleanupUnusedLinks")
}
// NOTE: all cleanup are done, future deprovisioning will not need to do this
// if err := network.CleanupUnusedLinks(); err != nil {
// return errors.Wrap(err, "failed to cleanupUnusedLinks")
// }

network.CleanupOrphanedNamespaces()
// network.CleanupOrphanedNamespaces()

if err := bootstrap.DefaultBridgeValid(); err != nil {
return errors.Wrap(err, "invalid setup")
Expand Down
2 changes: 1 addition & 1 deletion qemu/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ net:

run:
@echo "Running your node"
sudo ./vm.sh -g -n node-01 -c "farmer_id=$(id) version=v3 printk.devmsg=on runmode=dev nomodeset ssh-user=$(user)"
sudo ./vm.sh -m 8 -n node-01 -c "farmer_id=$(id) version=v3 printk.devmsg=on runmode=dev nomodeset ssh-user=$(user)"

run-gpu:
@echo "Running your node"
Expand Down