Skip to content

Conversation

@pingyu
Copy link
Collaborator

@pingyu pingyu commented Jan 5, 2026

Close #509

Changes

  • Cleanup locks on the beginning of each cases
    • To clean up possible leftover locks from previous cases.
  • Wait async commit completed for longer duration in txn_cleanup_async_commit_locks.
  • Only check for locks in range for txn_cleanup_range_async_commit_locks.
  • Check TTL for a range of 5s for raw_ttl in case the process takes long.

Manual Test:
https://github.com/tikv/client-rust/actions/runs/20704881948?pr=510
image

pingyu added 2 commits January 5, 2026 11:22
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2026
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 5, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 5, 2026

@iosmanthus: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iosmanthus, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [YuJuncen,iosmanthus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 5, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 5, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-05 05:35:56.190894918 +0000 UTC m=+594112.009203350: ☑️ agreed by iosmanthus.
  • 2026-01-05 08:23:53.654978434 +0000 UTC m=+604189.473286866: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 6fd16c9 into tikv:master Jan 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: "txn_cleanup_range_async_commit_locks" is flaky

3 participants