This repository was archived by the owner on Feb 4, 2022. It is now read-only.
Patch bootstrapper #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (isset($manifest['namespace'])) | ||
| { | ||
| $identifier = $manifest['identifier']; | ||
| $namespace = $manifest['namespace']; |
Contributor
Author
There was a problem hiding this comment.
This $namespace variable isn't used, is that intentional?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix some undefined variable erros & cache extended components to a local variable for performance
Why
2 variables are undefined if you don't bootstrap any components.
Also, iterating over the whole list of manifests twice is unnecessary, cache each component that is extending another and only iterate those extended components.