Skip to content

Add File Watcher for External Command Control #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothyfroehlich merged 7 commits into from
Jul 5, 2025

fix: resolve pre-commit whitespace and end-of-file issues

9acb168
Select commit
Loading
Failed to load commit list.
Merged

Add File Watcher for External Command Control #91

fix: resolve pre-commit whitespace and end-of-file issues
9acb168
Select commit
Loading
Failed to load commit list.
Cursor / Cursor BugBot completed Jul 5, 2025 in 2m 10s

BugBot Review

BugBot completed review and found 2 potential issues

Request ID: serverGenReqId_24e95918-1f90-43a5-94fe-5b2dd9203f48

Details

Bug: Incorrect Attribute Access Causes Errors

In the _show_monitoring_status method, the code accesses target.location_name when listing recent targets. This will cause an AttributeError because the MonitoringTarget model's attribute is display_name. Additionally, target.location_id can be null for geographic targets and should be handled to avoid displaying "None".

src/local_dev/console_discord.py#L279-L282

DisPinMap/src/local_dev/console_discord.py

Lines 279 to 282 in 9acb168

for target in recent_targets:
logger.info(
f" - {target.location_name} (ID: {target.location_id})"
)

Fix in Cursor • Fix in Web

Bug: Syntax Check Command Fails with Glob Patterns

The Python syntax check command python -m py_compile src/**/*.py is incorrect. The py_compile module expects individual file paths, not glob patterns, and the ** recursive glob may not be supported by all shells, leading to the check failing.

scripts/run_all_checks.sh#L69-L72

DisPinMap/scripts/run_all_checks.sh

Lines 69 to 72 in 9acb168

# 1. Python syntax check
run_check "Python Syntax Check" \
"python -m py_compile src/**/*.py" \
""

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

View more details on Cursor