-
Notifications
You must be signed in to change notification settings - Fork 0
Replace hardcoded green colors with semantic success tokens in dashboard #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hardcoded green colors with semantic success tokens in dashboard #869
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…tokens Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com>
Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com>
0459b40
into
feature/dashboard-recent-games
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses feedback from PR #868 by replacing hardcoded green color values with semantic Material Design 3 color tokens in the "Recently Fixed Games" dashboard section.
Changes:
- Added
glow-successutility toglobals.cssfollowing the existing glow utility pattern - Replaced all hardcoded green color classes (
green-500/30,green-500/10,green-400) with semantic tokens (success/30,success/10,success) - Applied consistent glow effect to Recently Fixed Games cards
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/globals.css | Adds new glow-success utility for success-themed glow effects following existing pattern |
| src/app/(app)/dashboard/page.tsx | Replaces hardcoded green colors with semantic success tokens in Recently Fixed Games section |
| @utility glow-success { | ||
| box-shadow: | ||
| 0 0 10px rgba(34, 197, 94, 0.5), | ||
| 0 0 20px rgba(34, 197, 94, 0.3); | ||
| } |
Copilot
AI
Jan 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The glow-success utility uses hardcoded RGBA color values rgba(34, 197, 94, ...) instead of leveraging the CSS variable --color-success. This violates the "No-Cruft" rule from the UI Guide which states "No Hardcoded Colors".
While the existing glow utilities (glow-primary, glow-secondary, etc.) also use hardcoded RGBA values, this presents an opportunity to improve the pattern. The hardcoded values create maintenance issues because if --color-success changes, the glow effect won't automatically match.
Consider using CSS color functions with the existing --color-success variable, or alternatively, define an RGB version of the success color in the @theme block that can be used with rgba().
#868) * feat(dashboard): replace unplayable machines with newest/recently fixed games - Remove "Unplayable Machines" section (cluttered, low value) - Add "Newest Games" row showing 3 most recently added machines - Add "Recently Fixed Games" row showing machines that went from major/unplayable issues to none, ordered by when last fixed - Reorder layout: Quick Stats → Newest → Fixed → Assigned to Me → Recent Issues - Update Issues Assigned to Me to use full-width grid layout Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Replace hardcoded green colors with semantic success tokens in dashboard (#869) * Initial plan * fix(dashboard): replace hardcoded green colors with semantic success tokens Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com> * feat(dashboard): add glow-success effect to Recently Fixed Games cards Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com> * test(e2e): update dashboard tests for newest/recently fixed games sections Replace "Unplayable Machines" section checks with new sections: - Newest Games: verifies heading and machines list or empty state - Recently Fixed Games: verifies heading and fixed machines list or empty state Fixes E2E test failures after dashboard refactor in 45baccd. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test(integration): replace unplayable machines test with newest/recently fixed Addresses Copilot review feedback: - Remove obsolete "Unplayable Machines Query" test - Add "Newest Machines Query" test (verifies 3 most recent by createdAt) - Add "Recently Fixed Machines Query" test (verifies complex SQL logic for machines that had major/unplayable issues but are now fully operational) Tests follow dashboard query patterns and include edge cases. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Addresses feedback from PR #868 to replace hardcoded green color values with semantic color tokens in the "Recently Fixed Games" section.
Changes
glow-successutility toglobals.cssfollowing existing glow utility patterngreen-500/30→success/30(border)green-500/10→success/10(background)green-400→success(text, icon)Example
This ensures consistency with the Material Design 3 color system and eliminates hardcoded color values per the UI Guide's "No-Cruft" rule.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.