Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Addresses feedback from PR #868 to replace hardcoded green color values with semantic color tokens in the "Recently Fixed Games" section.

Changes

  • Added glow-success utility to globals.css following existing glow utility pattern
  • Replaced hardcoded colors with semantic tokens:
    • green-500/30success/30 (border)
    • green-500/10success/10 (background)
    • green-400success (text, icon)
  • Applied glow effect to cards for consistency with Newest Games section

Example

// Before
<Card className="border-green-500/30 bg-green-500/10 hover:border-green-500">
  <CardTitle className="text-green-400">{machine.name}</CardTitle>
</Card>

// After
<Card className="border-success/30 bg-success/10 hover:border-success glow-success">
  <CardTitle className="text-success">{machine.name}</CardTitle>
</Card>

This ensures consistency with the Material Design 3 color system and eliminates hardcoded color values per the UI Guide's "No-Cruft" rule.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
pin-point Ready Ready Preview, Comment Jan 28, 2026 4:09am

…tokens

Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com>
Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com>
Copilot AI changed the title [WIP] Update dashboard feature for unplayable machines Replace hardcoded green colors with semantic success tokens in dashboard Jan 28, 2026
@timothyfroehlich timothyfroehlich marked this pull request as ready for review January 28, 2026 04:25
Copilot AI review requested due to automatic review settings January 28, 2026 04:25
@timothyfroehlich timothyfroehlich merged commit 0459b40 into feature/dashboard-recent-games Jan 28, 2026
2 checks passed
@timothyfroehlich timothyfroehlich deleted the copilot/sub-pr-868 branch January 28, 2026 04:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses feedback from PR #868 by replacing hardcoded green color values with semantic Material Design 3 color tokens in the "Recently Fixed Games" dashboard section.

Changes:

  • Added glow-success utility to globals.css following the existing glow utility pattern
  • Replaced all hardcoded green color classes (green-500/30, green-500/10, green-400) with semantic tokens (success/30, success/10, success)
  • Applied consistent glow effect to Recently Fixed Games cards

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/app/globals.css Adds new glow-success utility for success-themed glow effects following existing pattern
src/app/(app)/dashboard/page.tsx Replaces hardcoded green colors with semantic success tokens in Recently Fixed Games section

Comment on lines +103 to +107
@utility glow-success {
box-shadow:
0 0 10px rgba(34, 197, 94, 0.5),
0 0 20px rgba(34, 197, 94, 0.3);
}
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glow-success utility uses hardcoded RGBA color values rgba(34, 197, 94, ...) instead of leveraging the CSS variable --color-success. This violates the "No-Cruft" rule from the UI Guide which states "No Hardcoded Colors".

While the existing glow utilities (glow-primary, glow-secondary, etc.) also use hardcoded RGBA values, this presents an opportunity to improve the pattern. The hardcoded values create maintenance issues because if --color-success changes, the glow effect won't automatically match.

Consider using CSS color functions with the existing --color-success variable, or alternatively, define an RGB version of the success color in the @theme block that can be used with rgba().

Copilot uses AI. Check for mistakes.
timothyfroehlich added a commit that referenced this pull request Jan 28, 2026
#868)

* feat(dashboard): replace unplayable machines with newest/recently fixed games

- Remove "Unplayable Machines" section (cluttered, low value)
- Add "Newest Games" row showing 3 most recently added machines
- Add "Recently Fixed Games" row showing machines that went from
  major/unplayable issues to none, ordered by when last fixed
- Reorder layout: Quick Stats → Newest → Fixed → Assigned to Me → Recent Issues
- Update Issues Assigned to Me to use full-width grid layout

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Replace hardcoded green colors with semantic success tokens in dashboard (#869)

* Initial plan

* fix(dashboard): replace hardcoded green colors with semantic success tokens

Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com>

* feat(dashboard): add glow-success effect to Recently Fixed Games cards

Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: timothyfroehlich <5819722+timothyfroehlich@users.noreply.github.com>

* test(e2e): update dashboard tests for newest/recently fixed games sections

Replace "Unplayable Machines" section checks with new sections:
- Newest Games: verifies heading and machines list or empty state
- Recently Fixed Games: verifies heading and fixed machines list or empty state

Fixes E2E test failures after dashboard refactor in 45baccd.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* test(integration): replace unplayable machines test with newest/recently fixed

Addresses Copilot review feedback:
- Remove obsolete "Unplayable Machines Query" test
- Add "Newest Machines Query" test (verifies 3 most recent by createdAt)
- Add "Recently Fixed Machines Query" test (verifies complex SQL logic for machines that had major/unplayable issues but are now fully operational)

Tests follow dashboard query patterns and include edge cases.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants