Fixing issues #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fix was required to get |
|
Actually found the same issue when trying this fork. Not sure about your "error"-event since there is already a "failure"-event used for all errors, I just reused that instead. Also it didn't work in the latest electron versions 10, 11. So I fixed that in my fork: master...tillbaks:master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the
finishcallback signature, it wasn't aware of errors. Plus I'm emiting the found devices on thefinishedevent because it's really handy.It is not backwards compatible, as the user now MUST handle the
errorevent or else the app will crash.