Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Doc/library/socket.rst
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,9 @@ The AF_* and SOCK_* constants are now :class:`AddressFamily` and
.. versionchanged:: 3.14
Added support for ``TCP_QUICKACK`` on Windows platforms when available.

.. versionchanged:: next
``IPV6_HDRINCL`` was added.


.. data:: AF_CAN
PF_CAN
Expand Down
8 changes: 6 additions & 2 deletions Lib/pickletools.py
Original file line number Diff line number Diff line change
Expand Up @@ -2839,7 +2839,7 @@ def __init__(self, value):
}


if __name__ == "__main__":
def _main(args=None):
import argparse
parser = argparse.ArgumentParser(
description='disassemble one or more pickle files',
Expand All @@ -2864,7 +2864,7 @@ def __init__(self, value):
'-p', '--preamble', default="==> {name} <==",
help='if more than one pickle file is specified, print this before'
' each disassembly')
args = parser.parse_args()
args = parser.parse_args(args)
annotate = 30 if args.annotate else 0
memo = {} if args.memo else None
if args.output is None:
Expand All @@ -2885,3 +2885,7 @@ def __init__(self, value):
finally:
if output is not sys.stdout:
output.close()


if __name__ == "__main__":
_main()
2 changes: 0 additions & 2 deletions Lib/test/test_capi/test_opt.py
Original file line number Diff line number Diff line change
Expand Up @@ -2480,8 +2480,6 @@ def testfunc(n):


testfunc(_testinternalcapi.TIER2_THRESHOLD)
ex = get_first_executor(testfunc)
assert ex is not None
"""))

def test_pop_top_specialize_none(self):
Expand Down
168 changes: 168 additions & 0 deletions Lib/test/test_pickletools.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import io
import itertools
import pickle
import pickletools
import tempfile
import textwrap
from test import support
from test.support import os_helper
from test.pickletester import AbstractPickleTests
import doctest
import unittest
Expand Down Expand Up @@ -514,6 +518,170 @@ def test__all__(self):
support.check__all__(self, pickletools, not_exported=not_exported)


class CommandLineTest(unittest.TestCase):
def setUp(self):
self.filename = tempfile.mktemp()
self.addCleanup(os_helper.unlink, self.filename)

@staticmethod
def text_normalize(string):
return textwrap.dedent(string).strip()

def set_pickle_data(self, data):
with open(self.filename, 'wb') as f:
pickle.dump(data, f)

def invoke_pickletools(self, *flags):
with (
support.captured_stdout() as stdout,
support.captured_stderr() as stderr,
):
pickletools._main(args=[*flags, self.filename])
self.assertEqual(stderr.getvalue(), '')
return self.text_normalize(stdout.getvalue())

def check_output(self, data, expect, *flags):
with self.subTest(data=data, flags=flags):
self.set_pickle_data(data)
res = self.invoke_pickletools(*flags)
expect = self.text_normalize(expect)
self.assertListEqual(res.splitlines(), expect.splitlines())

def test_invocation(self):
# test various combinations of parameters
output_file = tempfile.mktemp()
self.addCleanup(os_helper.unlink, output_file)
base_flags = [
(f'-o={output_file}', f'--output={output_file}'),
('-m', '--memo'),
('-l=2', '--indentlevel=2'),
('-a', '--annotate'),
('-p="Another:"', '--preamble="Another:"'),
]
data = { 'a', 'b', 'c' }

self.set_pickle_data(data)

for r in range(1, len(base_flags) + 1):
for choices in itertools.combinations(base_flags, r=r):
for args in itertools.product(*choices):
with self.subTest(args=args[1:]):
self.invoke_pickletools(*args)

def test_unknown_flag(self):
with self.assertRaises(SystemExit):
with support.captured_stderr() as stderr:
pickletools._main(args=['--unknown'])
self.assertStartsWith(stderr.getvalue(), 'usage: ')

def test_output_flag(self):
# test 'python -m pickletools -o/--output'
output_file = tempfile.mktemp()
self.addCleanup(os_helper.unlink, output_file)
data = ('fake_data',)
expect = r'''
0: \x80 PROTO 5
2: \x95 FRAME 15
11: \x8c SHORT_BINUNICODE 'fake_data'
22: \x94 MEMOIZE (as 0)
23: \x85 TUPLE1
24: \x94 MEMOIZE (as 1)
25: . STOP
highest protocol among opcodes = 4
'''
for flag in [f'-o={output_file}', f'--output={output_file}']:
with self.subTest(data=data, flags=flag):
self.set_pickle_data(data)
res = self.invoke_pickletools(flag)
with open(output_file, 'r') as f:
res_from_file = self.text_normalize(f.read())
expect = self.text_normalize(expect)

self.assertListEqual(res.splitlines(), [])
self.assertListEqual(res_from_file.splitlines(),
expect.splitlines())

def test_memo_flag(self):
# test 'python -m pickletools -m/--memo'
data = ('fake_data',)
expect = r'''
0: \x80 PROTO 5
2: \x95 FRAME 15
11: \x8c SHORT_BINUNICODE 'fake_data'
22: \x94 MEMOIZE (as 0)
23: \x85 TUPLE1
24: \x94 MEMOIZE (as 1)
25: . STOP
highest protocol among opcodes = 4
'''
for flag in ['-m', '--memo']:
self.check_output(data, expect, flag)

def test_indentlevel_flag(self):
# test 'python -m pickletools -l/--indentlevel'
data = ('fake_data',)
expect = r'''
0: \x80 PROTO 5
2: \x95 FRAME 15
11: \x8c SHORT_BINUNICODE 'fake_data'
22: \x94 MEMOIZE (as 0)
23: \x85 TUPLE1
24: \x94 MEMOIZE (as 1)
25: . STOP
highest protocol among opcodes = 4
'''
for flag in ['-l=2', '--indentlevel=2']:
self.check_output(data, expect, flag)

def test_annotate_flag(self):
# test 'python -m pickletools -a/--annotate'
data = ('fake_data',)
expect = r'''
0: \x80 PROTO 5 Protocol version indicator.
2: \x95 FRAME 15 Indicate the beginning of a new frame.
11: \x8c SHORT_BINUNICODE 'fake_data' Push a Python Unicode string object.
22: \x94 MEMOIZE (as 0) Store the stack top into the memo. The stack is not popped.
23: \x85 TUPLE1 Build a one-tuple out of the topmost item on the stack.
24: \x94 MEMOIZE (as 1) Store the stack top into the memo. The stack is not popped.
25: . STOP Stop the unpickling machine.
highest protocol among opcodes = 4
'''
for flag in ['-a', '--annotate']:
self.check_output(data, expect, flag)

def test_preamble_flag(self):
# test 'python -m pickletools -p/--preamble'
data = ('fake_data',)
expect = r'''
Another:
0: \x80 PROTO 5
2: \x95 FRAME 15
11: \x8c SHORT_BINUNICODE 'fake_data'
22: \x94 MEMOIZE (as 0)
23: \x85 TUPLE1
24: \x94 MEMOIZE (as 1)
25: . STOP
highest protocol among opcodes = 4
Another:
0: \x80 PROTO 5
2: \x95 FRAME 15
11: \x8c SHORT_BINUNICODE 'fake_data'
22: \x94 MEMOIZE (as 0)
23: \x85 TUPLE1
24: \x94 MEMOIZE (as 1)
25: . STOP
highest protocol among opcodes = 4
'''
for flag in ['-p=Another:', '--preamble=Another:']:
with self.subTest(data=data, flags=flag):
self.set_pickle_data(data)
with support.captured_stdout() as stdout:
pickletools._main(args=[flag, self.filename, self.filename])
res = self.text_normalize(stdout.getvalue())
expect = self.text_normalize(expect)
self.assertListEqual(res.splitlines(), expect.splitlines())


def load_tests(loader, tests, pattern):
tests.addTest(doctest.DocTestSuite(pickletools))
return tests
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add :data:`!socket.IPV6_HDRINCL` constant.
18 changes: 10 additions & 8 deletions Modules/_ssl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1437,14 +1437,14 @@ _get_peer_alt_names (_sslmodulestate *state, X509 *certificate) {
}
PyTuple_SET_ITEM(t, 0, v);

if (name->d.ip->length == 4) {
unsigned char *p = name->d.ip->data;
if (ASN1_STRING_length(name->d.ip) == 4) {
const unsigned char *p = ASN1_STRING_get0_data(name->d.ip);
v = PyUnicode_FromFormat(
"%d.%d.%d.%d",
p[0], p[1], p[2], p[3]
);
} else if (name->d.ip->length == 16) {
unsigned char *p = name->d.ip->data;
} else if (ASN1_STRING_length(name->d.ip) == 16) {
const unsigned char *p = ASN1_STRING_get0_data(name->d.ip);
v = PyUnicode_FromFormat(
"%X:%X:%X:%X:%X:%X:%X:%X",
p[0] << 8 | p[1],
Expand Down Expand Up @@ -1575,8 +1575,9 @@ _get_aia_uri(X509 *certificate, int nid) {
continue;
}
uri = ad->location->d.uniformResourceIdentifier;
ostr = PyUnicode_FromStringAndSize((char *)uri->data,
uri->length);
ostr = PyUnicode_FromStringAndSize(
(const char *)ASN1_STRING_get0_data(uri),
ASN1_STRING_length(uri));
if (ostr == NULL) {
goto fail;
}
Expand Down Expand Up @@ -1642,8 +1643,9 @@ _get_crl_dp(X509 *certificate) {
continue;
}
uri = gn->d.uniformResourceIdentifier;
ouri = PyUnicode_FromStringAndSize((char *)uri->data,
uri->length);
ouri = PyUnicode_FromStringAndSize(
(const char *)ASN1_STRING_get0_data(uri),
ASN1_STRING_length(uri));
if (ouri == NULL)
goto done;

Expand Down
3 changes: 3 additions & 0 deletions Modules/socketmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -8901,6 +8901,9 @@ socket_exec(PyObject *m)
#ifdef IPV6_HOPLIMIT
ADD_INT_MACRO(m, IPV6_HOPLIMIT);
#endif
#ifdef IPV6_HDRINCL
ADD_INT_MACRO(m, IPV6_HDRINCL);
#endif
#ifdef IPV6_HOPOPTS
ADD_INT_MACRO(m, IPV6_HOPOPTS);
#endif
Expand Down
Loading