Disc added to the primitives in CloudCompare #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: the disc primitive in now merged in the master branch of CloudCompare. |
Owner
|
I'll take a look |
dgirardeau
approved these changes
Nov 26, 2025
Contributor
Author
|
I don't understand why Wheels.yml fails. |
Owner
|
Its because I forgot to also downgrade the qt version in the build wheels file However, I wonder if CloudCompare should remove the options that causes the problems from the windeployqt invocation instead of pinning down, unless the windeployqt in the conda package is somehow bad |
Collaborator
|
maybe @rjanvier has an idea? (he's currently looking at this stuff I believe) |
tmontaigu
force-pushed
the
master_disc
branch
from
a75904c to
c325bf3
Compare
tmontaigu
force-pushed
the
master_disc
branch
from
c325bf3 to
fbaba7d
Compare
Owner
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR is open in the CloudCompare repository with the disc primitive added to the existing ones.