Fix submissions visibility for approvers & checkpoint-reviewers #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| resources, | ||
| }: ChallengeDetailContextModel = useContext(ChallengeDetailContext) | ||
| const { actionChallengeRole, isPrivilegedRole }: useRoleProps = useRole() | ||
| const { actionChallengeRole, isPrivilegedRole, hasApproverRole }: useRoleProps = useRole() |
There was a problem hiding this comment.
[correctness]
The addition of hasApproverRole to the destructured object from useRole() should be verified to ensure that it is correctly implemented and used throughout the component. Ensure that useRole() is returning hasApproverRole as expected.
| const validReviewPhaseSubmissions = baseReviews.filter(hasReviewPhaseReview) | ||
|
|
||
| if (isPrivilegedRole || (isChallengeCompleted && hasPassedReviewThreshold)) { | ||
| if (isPrivilegedRole || hasApproverRole || (isChallengeCompleted && hasPassedReviewThreshold)) { |
There was a problem hiding this comment.
[correctness]
The condition now includes hasApproverRole, which changes the logic for determining valid review phase submissions. Ensure that this change aligns with the intended business logic and that hasApproverRole is correctly set for users who should have access.
kkartunov
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-2631 - Design 2 round: Checkpoint reviewer doesn't see any data on checkpoint submissions and checkpoint screening tabs and also on review tab
https://topcoder.atlassian.net/browse/PM-2663 - Design Ch: Approvers dont seen screening and review details
What's in this PR?
Allow approvers to see submissions in the screening & reivews tabs
Allow checkpoint reviewers to see the submissions in the checkpoint screening & submissions tabs.