Enhanced Topgear hourly report by adding registration and submission … #39
Conversation
…end dates from challenge phases
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| registration_end AS ( | ||
| SELECT | ||
| cp."challengeId" AS challenge_id, | ||
| MAX(COALESCE(cp."actualEndDate", cp."scheduledEndDate")) AS registration_end_date |
There was a problem hiding this comment.
[correctness]
Using MAX(COALESCE(cp."actualEndDate", cp."scheduledEndDate")) to determine the registration_end_date assumes that the maximum of these dates is always the correct end date. Consider whether this logic accurately reflects the business rules, as it may not account for scenarios where the scheduled end date should take precedence over the actual end date.
| submission_end AS ( | ||
| SELECT | ||
| cp."challengeId" AS challenge_id, | ||
| MAX(COALESCE(cp."actualEndDate", cp."scheduledEndDate")) AS submission_end_date |
There was a problem hiding this comment.
[correctness]
Using MAX(COALESCE(cp."actualEndDate", cp."scheduledEndDate")) to determine the submission_end_date assumes that the maximum of these dates is always the correct end date. Ensure this logic aligns with the intended business rules, as it may not handle cases where the scheduled end date should override the actual end date.
|
Looks good to me, thanks |
…end dates from challenge phases