Optimized the hourly report sql query #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| MAX(COALESCE(cp."actualEndDate", cp."scheduledEndDate")) AS registration_end_date | ||
| FROM challenges."ChallengePhase" cp | ||
| JOIN challenges."Phase" p ON p.id = cp."phaseId" | ||
| JOIN base_challenges bc ON bc.id = cp."challengeId" |
There was a problem hiding this comment.
[correctness]
Ensure that the base_challenges CTE is correctly filtering and joining with ChallengePhase. If base_challenges does not contain all relevant challengeId values, this join may exclude necessary data.
| MAX(COALESCE(cp."actualEndDate", cp."scheduledEndDate")) AS submission_end_date | ||
| FROM challenges."ChallengePhase" cp | ||
| JOIN challenges."Phase" p ON p.id = cp."phaseId" | ||
| JOIN base_challenges bc ON bc.id = cp."challengeId" |
There was a problem hiding this comment.
[correctness]
Verify that the base_challenges CTE includes all challengeId values needed for the submission_end CTE. If base_challenges is too restrictive, it could lead to missing data in the final report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.