Skip to content

Conversation

@sammuti
Copy link
Contributor

@sammuti sammuti commented Sep 17, 2025

  • Introduce black pre-commit hook
  • Format existing code

@github-actions

This comment was marked as resolved.

@sammuti sammuti requested review from jo-sm and socksy September 17, 2025 15:11
Copy link
Contributor

@socksy socksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin good! I know it's in draft but already an improvement. If you add a --check command to one of the github workflows (maybe .github/workflows/test-python.yml?) and a line in the README for how to run it, that'd be grand

@socksy socksy changed the base branch from main to develop September 17, 2025 16:17
@sammuti
Copy link
Contributor Author

sammuti commented Sep 18, 2025

@socksy here I also added a git precommit hook so it will run automatically when you commit.
image

@sammuti sammuti marked this pull request as ready for review September 18, 2025 07:44
@sammuti
Copy link
Contributor Author

sammuti commented Sep 18, 2025

mistake, I need to make a change so that it will be available to you locally

@sammuti sammuti requested a review from socksy September 18, 2025 08:13
@sammuti
Copy link
Contributor Author

sammuti commented Sep 18, 2025

@socksy now PRs will also check formatting

image

I also added instructions on installing the pre-commit hook, so it would be less hassle for everyone to use

Copy link
Contributor

@bradhe bradhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sammuti sammuti merged commit 1d77f4d into develop Sep 18, 2025
21 checks passed
@sammuti sammuti deleted the intro_black branch September 18, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants