Remove inherited environments #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradhe
force-pushed
the
tasks/do-not-inherit-full-environment
branch
from
e5fbb48 to
a24214a
Compare
socksy
approved these changes
Oct 2, 2025
bradhe
added a commit
that referenced
this pull request
Oct 7, 2025
* feat: add --json output support * refactor: move hardcoded colors in apps output to output.rs helper fns * feature: make integration tests work with mock session.json * test: add app management integration tests for CLI * refactor: use early returns to avoid such a large diff * chore: update error and success to work with --json * chore: you may think you can outrun the borrow checker, but the borrow checker will always win * chore: fix test * Merge pull request #104 from tower/tasks/do-not-inherit-full-environment Remove inherited environments --------- Co-authored-by: Ben Lovell <ben.j.lovell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids us leaking secret data, etc., to subprocesses that have user-defined code in them. Shout out to @melgenek on this.