Update generated client 2025 09 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we see a null value for a required field, the generated code will now instruct serde to give it the default value (e.g. "" for string, [] for array, etc). This may be nonsense, of course, but it's less likely to be nonsense than "null", and makes the CLI a whole lot less brittle to bugs on the backend - a single null value shouldn't kill the rest of a response!
bradhe
approved these changes
Sep 30, 2025
Contributor
bradhe
left a comment
bradhe
left a comment
There was a problem hiding this comment.
These look like good additions, let's add them in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bradhe looks like we were working on this simultaneously. I made a couple small changes to the generation (formatting and default values on nulls), and rebased on yours