Add tool call & some other params support for llms api #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is targeting If this is a regular feature/fix PR, please change the base branch to Current base: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tool call support to the LLMs API, enabling function calling capabilities for both Ollama and Hugging Face Hub inference routers.
- Extended the
complete_chatmethod to accept additional parameters via**kwargsincluding tool definitions - Modified return types to support both string responses and full response objects when tools are involved
- Updated both Ollama and Hugging Face Hub implementations to handle tool calls and return appropriate response formats
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sammuti
changed the title
sammuti
changed the title
bradhe
approved these changes
Oct 16, 2025
Contributor
bradhe
left a comment
bradhe
left a comment
There was a problem hiding this comment.
Looks good, let's ship it.
bradhe
pushed a commit
that referenced
this pull request
Nov 2, 2025
Add tool call & some other params support for llms api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tool call support for llms api