[TOW-1316] Validate 50MB Limit for deployment package size #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammuti
requested review from
bradhe,
Copilot,
giray123,
jo-sm,
konstantinoscs and
socksy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements validation for a 50MB deployment package size limit. The changes ensure that bundle deployments fail gracefully with a clear error message when attempting to upload packages that exceed this threshold.
Key Changes:
- Introduced a
MAX_BUNDLE_SIZEconstant set to 50MB in the package crate - Added size validation before upload with user-friendly error messaging
- Applied formatting fixes to improve code consistency
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/tower-package/src/lib.rs | Defines the 50MB maximum bundle size constant |
| crates/tower-cmd/src/util/deploy.rs | Implements bundle size validation with error message before upload |
| crates/tower-telemetry/src/logging.rs | Formatting improvements for multi-line method chains |
| crates/tower-runtime/tests/local_test.rs | Formatting fix for trailing comma |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bradhe
reviewed
Dec 31, 2025
bradhe
approved these changes
Dec 31, 2025
Contributor
bradhe
left a comment
bradhe
left a comment
There was a problem hiding this comment.
Looks good overall, one minor change to messaging then you can land it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate 50MB Limit for deployment package size