[TOW-1275] Emit proper error message for not logged in when running cmd #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammuti
requested review from
bradhe,
Copilot,
giray123,
jo-sm and
konstantinoscs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling by replacing generic error messages with proper error reporting through output::tower_error(), ensuring users receive appropriate feedback (e.g., when not logged in) when commands fail.
Key Changes:
- Replaced generic "There was a problem with the Tower API" messages with
output::tower_error()calls - Converted
if letpatterns tomatchexpressions for consistent error handling - Added explicit
std::process::exit(1)calls after error handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/tower-cmd/src/secrets.rs | Updated error handling in do_create, do_delete, and encrypt_and_create_secret to use tower_error() and explicit process exits |
| crates/tower-cmd/src/run.rs | Replaced debug logging with tower_error() calls in get_secrets and get_catalogs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bradhe
requested changes
Jan 2, 2026
Contributor
bradhe
left a comment
bradhe
left a comment
There was a problem hiding this comment.
Couple small things, it's on the right track.
- We should move the logic for error handling up a level in the
get_secretsAPI wrapper. We don't want the API logic managing the output state. - Let's create a
tower_error_and_diefunction and use it instead of callingexitdirectly to normalize exit codes.secrets::do_createshould be updated to address this I think.
Contributor
Author
|
@bradhe I've made an update to refactor spinner and error handling to be more consistent everywhere while taking your feedback into account. With this change all commands look like follows with login error |
bradhe
approved these changes
Jan 2, 2026
Contributor
bradhe
left a comment
bradhe
left a comment
There was a problem hiding this comment.
I'm generally good moving forward with what we have here; however, there's one improvement I suggested. It'd be ideal if you could implement that, then land this thing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit proper error message for not logged in when running cmd
eg: