Skip to content

Conversation

@bradhe
Copy link
Contributor

@bradhe bradhe commented May 8, 2025

  • Upgrade Rust client, fixing bugs in how secrets are deleted and how they are exported.
  • Upgrade Python client while we're at it
  • Bump version to v0.3.13
  • Fix login bug when users can't launch a browser

@bradhe bradhe requested review from Copilot and sankroh May 8, 2025 12:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the OpenAPI document version from v0.5.9 to v0.5.12, introduces a new export_catalogs API endpoint with its corresponding structures, updates the export_secrets method to use POST with JSON parameters, and adjusts Cargo.toml to use workspace attributes for versioning and metadata.

  • Updated API version documentation across files
  • Addition of new export_catalogs API and modifications to export_secrets API
  • Adjustment of Cargo.toml metadata to align with workspace configuration

Reviewed Changes

Copilot reviewed 136 out of 136 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/tower-api/src/models/*.rs Updated OpenAPI document version to v0.5.12 in API model comments
crates/tower-api/src/apis/default_api.rs Added export_catalogs API endpoint and updated export_secrets API implementation
crates/tower-api/src/apis/configuration.rs Updated OpenAPI document version to v0.5.12 in configuration documentation
crates/tower-api/README.md Updated API version and documentation references to v0.5.12
crates/tower-api/Cargo.toml Changed versioning and metadata to use workspace attributes
Comments suppressed due to low confidence (2)

crates/tower-api/src/apis/default_api.rs:560

  • Changing DeleteSecretSuccess from Status204() to Status200 with a response model may affect clients that expect no body in deletion responses. Please confirm that the API design and client contracts have been updated accordingly.
Status200(models::DeleteSecretResponse),

crates/tower-api/src/apis/default_api.rs:2325

  • The new export_catalogs endpoint now uses POST with a JSON body instead of a GET request. Please verify that this change aligns with the overall API design and client expectations for catalog exports.
pub async fn export_catalogs(configuration: &configuration::Configuration, params: ExportCatalogsParams) -> Result<ResponseContent<ExportCatalogsSuccess>, Error<ExportCatalogsError>> {

Copy link
Contributor

@sankroh sankroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bradhe bradhe merged commit ad43737 into main May 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants