Skip to content

Handle field type mappings correctly #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sankroh merged 5 commits into from
May 13, 2025
Merged

Handle field type mappings correctly #49

sankroh merged 5 commits into from
May 13, 2025

Conversation

@sankroh
Copy link
Contributor

@sankroh sankroh commented May 13, 2025 •
edited
Loading

This PR:

  • fixes the arrow type to iceberg type mapping for fields with timestamptz types
  • fixes the handling of ids and nested datatypes like Lists and Structs
  • applies formatting to the code
  • adds tests for the various type mappings

@sankroh sankroh requested a review from bradhe May 13, 2025 04:57
@sankroh sankroh changed the title Handle TimestampTZ field types correctly Handle field type mappings correctly May 13, 2025
bradhe
bradhe approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@bradhe bradhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, great work! Super helpful.

@sankroh sankroh merged commit 6dd8ab4 into develop May 13, 2025
17 checks passed
@sankroh sankroh deleted the feature/tow-415-tower-cli-arrow-types-to-iceberg-types-dont-handle branch May 13, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradhe bradhe bradhe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sankroh @bradhe