Skip to content

Conversation

@bradhe
Copy link
Contributor

@bradhe bradhe commented Jun 5, 2025

  • New telemetry system that makes tracing runs easier
  • Upgrade the python and rust clients to support the latest API

@bradhe bradhe requested a review from Copilot June 5, 2025 22:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the existing log::debug! calls with the new tower_telemetry::debug! macro and wires in the tower-telemetry crate as the logging backend, while also removing the old log and simple_logger dependencies. Tests and runtime behavior remain unchanged; the main impacts are on how debug traces are emitted.

  • Swapped log::debug! invocations for debug! from tower_telemetry across all crates.
  • Removed log and simple_logger dependencies and added tower-telemetry everywhere.
  • Updated the AppLauncher::launch call to accept a new Context parameter, and switched to enable_logging.

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/tower-package/src/lib.rs Imported tower_telemetry::debug; replaced log::debug
crates/tower-package/src/error.rs Ditto for error conversions
crates/tower-package/Cargo.toml Removed log, added tower-telemetry
crates/tower-cmd/src/util/deploy.rs Replaced log::debug and imported debug
crates/tower-cmd/src/teams.rs Ditto
crates/tower-cmd/src/session.rs Ditto
crates/tower-cmd/src/secrets.rs Ditto
crates/tower-cmd/src/run.rs Replaced log::debug, imported Context, debug, updated .launch
crates/tower-cmd/src/output.rs Replaced log::debug in error handling
crates/tower-cmd/src/lib.rs Removed simple_logger, replaced set_max_level with enable_logging
crates/tower-cmd/src/error.rs Ditto for crypto error
crates/tower-cmd/src/deploy.rs Ditto
crates/tower-cmd/src/api.rs Ditto for API traces
crates/tower-cmd/Cargo.toml Removed logging crates, added tower-telemetry
crates/tower-api/Cargo.toml Removed log, added tower-telemetry
crates/config/src/towerfile.rs Replaced log::debug
crates/config/src/session.rs Ditto
crates/config/src/error.rs Removed extra println!, now only debug!
crates/config/Cargo.toml Removed log, added tower-telemetry
Cargo.toml Removed global log and simple_logger, added tracing deps
Comments suppressed due to low confidence (2)

crates/config/src/error.rs:47

  • [nitpick] The original println! for TOML parsing errors was removed, so end users no longer see the raw error. If this message is still helpful for troubleshooting when debug logging is disabled, consider emitting a user-facing error or restoring a visible output path.
debug!("error parsing Towerfile Toml: {}", err);

crates/tower-cmd/src/run.rs:134

  • The signature of AppLauncher::launch was modified to include Context::new() as the first argument; verify that this matches the updated API definition and update any documentation or trait implementations that expect the old signature.
.launch(Context::new(), sender, package, env, secrets, params, catalogs)

@bradhe bradhe merged commit da4a467 into main Jun 6, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants