Skip to content

Conversation

@HiteshMittal07
Copy link
Contributor

This PR updates auto_generate_corpora to collect failures from all targets instead of stopping at the first error. All identified failures are now reported collectively at the end of the process.

Key Changes:

  • Modified auto_generate_corpora to aggregate errors into a single message.
  • Added an integration test ( multiple_failures.rs ) to verify that failures from multiple targets are correctly captured and displayed together.

Fixes #677

mod generic_args;
mod replay;
mod warning;
mod multiple_failures;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can dispense with the test for this change.

target
);
eprintln!("Auto-generated `{}`.", corpus_dir.to_string_lossy());
let _ = auto_generate_corpus(executable, target);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that this error not be discarded.

Would it be possible to have the entries in errors be either this kind of error or the kind issued on line 1326 below?

@juice928
Copy link

👋 Hi, I'm an automated AI code review bot. I ran some checks on this PR and found 1 point that might be worth attention (could be false positives, please use your judgment):

  1. Error details in corpus generation could be more visible to improve debuggability
    • cargo-test-fuzz/src/lib.rs:L1325: cargo-test-fuzz/src/lib.rs:L1325
    • Impact: Specific causes for failure (like file permissions or disk space) are currently replaced by a generic message, making troubleshooting harder.
    • Suggestion: Consider capturing the Err result from auto_generate_corpus and including it in the errors vector to provide clearer feedback to the user.

If you find these suggestions disruptive, you can reply "stop" , and I'll automatically skip this repository in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show all targets for which corpora could not be generated

3 participants