Introduce fetch translations timeout setting #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foteinigk
force-pushed
the
fetch_translation_timout
branch
from
25bcdea to
0f0b0f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new configuration setting: FETCH_TRANSLATION_TIMEOUT, which allows callers to define a maximum time (in seconds) to wait when fetching translations or locales from CDS.
Previously, if CDS continued returning 202 Accepted for an extended period (e.g., when a job is stuck in a stale state), the system would keep retrying indefinitely. This new setting provides an additional safety mechanism—similar to the behavior offered by the Transifex JavaScript SDK—by enforcing an upper bound on how long we wait for CDS to produce a final result.
The default value is 0, meaning no global timeout, preserving existing behavior unless explicitly configured.