Feeder add ci and prod #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage ? 30.12%
=======================================
Files ? 8
Lines ? 664
Branches ? 0
=======================================
Hits ? 200
Misses ? 437
Partials ? 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlCutter
force-pushed
the
feeder_add_staging_and_prod
branch
4 times, most recently
from
50d8024 to
7b06153
Compare
mhutchinson
reviewed
Sep 24, 2025
| inputs = merge( | ||
| include.root.locals, | ||
| { | ||
| feeder_docker_image = "us-central1-docker.pkg.dev/checkpoint-distributor/distributor-docker-dev/feeder:latest" |
Contributor
There was a problem hiding this comment.
Are we happy with this being latest? It means any breakage will roll out to here at the same time as staging.
Contributor
Author
There was a problem hiding this comment.
Yeah, at the moment I think this is fine as it's all a bit early-stage anyway.
AlCutter
force-pushed
the
feeder_add_staging_and_prod
branch
4 times, most recently
from
80f41d0 to
148e553
Compare
mhutchinson
approved these changes
Sep 25, 2025
AlCutter
force-pushed
the
feeder_add_staging_and_prod
branch
4 times, most recently
from
b124cc2 to
644fd2c
Compare
AlCutter
force-pushed
the
feeder_add_staging_and_prod
branch
from
644fd2c to
48f3cd9
Compare
mhutchinson
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ci and prod feeder instances to match the other deployments in here.
devfeeds only the OmniGCP dev instancecifeeds only the CI AW devicesprodfeeds only the prod AW devices.