Don't escape plus signs in URLs (#621) #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! |
mrtmm
pushed a commit
to mrtmm/xblock-markdown
that referenced
this pull request
Aug 1, 2025
In version 2.5.4, markdown2 has added better handling for URLs containing a "+" sign (trentm/python-markdown2#623) Update our tests accordingly.
mrtmm
pushed a commit
to mrtmm/xblock-markdown
that referenced
this pull request
Aug 1, 2025
In version 2.5.4, markdown2 has added better handling for URLs containing a "+" sign (trentm/python-markdown2#623) Update our tests accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #621 by changing
_html_escape_urlto no longer escape+characters.As pointed out in #621,
+is a valid URL character, and therefore shouldn't be escaped in URLs.I'm not sure exactly why they were being escaped in the first place, although it seems the first usage comes from 000343d as part of #230:
quote_plusreplaces spaces with plus signs, and I'm guessing escapes some other characters too. They then go back and replace the plus signs with spaces again. Seems redundant and doesn't look like we need it