-
Notifications
You must be signed in to change notification settings - Fork 9
Add design document for the operator architecture #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add design document for the operator architecture #158
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Jakob-Naucke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the write-up. A couple of comments.
|
|
||
| #### Secret Provisioning Process | ||
|
|
||
| - Creates Kubernetes owner reference linking the secret to the Machine object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could mention the endpoint here too like you do for AK reg further below. I think it makes it clearer what happens technically.
|
/test operator-lifecycle-verify |
|
@alicefr: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Please ignore the test-related messages. I had planned to test concurrent runs, but I forgot that the fix hasn’t been merged yet. The latest fix now skips tests for documentation changes. |
2cb48a4 to
a9d9c67
Compare
docs/design/operator-architecture.md
Outdated
| 1. **Registration Server**: HTTP service that handles initial machine registration and Ignition configuration delivery. Deployes in the *registration server*. | ||
| 2. **AttestationKey Controller**: Manages attestation key registration and approval. Deployed in the *register-ak* pod. | ||
| 3. **Trustee Integration**: Updates Trustee deployment with secrets and attestation keys for node verification. Part of the *operator* pod. | ||
| 4. **Machine Controller**: Reconciles Machine custom resources representing individual nodes. Part of the *operator* pod | ||
| 5. **Secret Management**: Generates and manages LUKS. encryption keys and attestation key secrets. Part of the *operator* pod. | ||
| 6. **Attestation Server**: [Trustee](https://github.com/confidential-containers/trustee) deployment handle the attestation request | ||
| 7. **Reference Values calculation**: calculate the reference values provided by the approved images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
| 1. **Registration Server**: HTTP service that handles initial machine registration and Ignition configuration delivery. Deployes in the *registration server*. | |
| 2. **AttestationKey Controller**: Manages attestation key registration and approval. Deployed in the *register-ak* pod. | |
| 3. **Trustee Integration**: Updates Trustee deployment with secrets and attestation keys for node verification. Part of the *operator* pod. | |
| 4. **Machine Controller**: Reconciles Machine custom resources representing individual nodes. Part of the *operator* pod | |
| 5. **Secret Management**: Generates and manages LUKS. encryption keys and attestation key secrets. Part of the *operator* pod. | |
| 6. **Attestation Server**: [Trustee](https://github.com/confidential-containers/trustee) deployment handle the attestation request | |
| 7. **Reference Values calculation**: calculate the reference values provided by the approved images. | |
| 1. **Registration Server**: HTTP service that handles initial machine registration and Ignition configuration delivery. Deploys in the *registration server* pod. | |
| 2. **AttestationKey Controller**: Manages attestation key registration and approval. Deployed in the *attestation key registration server* pod. | |
| 3. **Trustee Integration**: Updates Trustee deployment with secrets and attestation keys for node verification. Part of the *operator* pod. | |
| 4. **Machine Controller**: Reconciles Machine custom resources representing individual nodes. Part of the *operator* pod. | |
| 5. **Secret Management**: Generates and manages LUKS encryption keys and attestation key secrets. Part of the *operator* pod. | |
| 6. **Attestation Server**: [Trustee](https://github.com/confidential-containers/trustee) deployment handle the attestation request | |
| 7. **Reference Values calculation**: Calculates the reference values provided by the approved images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deployment is although called register-ak :). Maybe not the best name, I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I think then they should all be named by pod, and speaking even more technically, it's attestation-key-register
Signed-off-by: Alice Frosi <afrosi@redhat.com>
a9d9c67 to
0f5b181
Compare
No description provided.