Skip to content

Conversation

@alicefr
Copy link
Contributor

@alicefr alicefr commented Jan 15, 2026

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alicefr

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@Jakob-Naucke Jakob-Naucke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the write-up. A couple of comments.


#### Secret Provisioning Process

- Creates Kubernetes owner reference linking the secret to the Machine object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could mention the endpoint here too like you do for AK reg further below. I think it makes it clearer what happens technically.

@yalzhang
Copy link
Contributor

/test operator-lifecycle-verify

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2026

@alicefr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/infra-provision-verify 2cb48a4 link true /test infra-provision-verify
ci/prow/operator-lifecycle-verify 2cb48a4 link true /test operator-lifecycle-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yalzhang
Copy link
Contributor

yalzhang commented Jan 18, 2026

@alicefr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Please ignore the test-related messages. I had planned to test concurrent runs, but I forgot that the fix hasn’t been merged yet. The latest fix now skips tests for documentation changes.

@alicefr alicefr force-pushed the design-architecture branch from 2cb48a4 to a9d9c67 Compare January 28, 2026 14:42
Comment on lines 13 to 19
1. **Registration Server**: HTTP service that handles initial machine registration and Ignition configuration delivery. Deployes in the *registration server*.
2. **AttestationKey Controller**: Manages attestation key registration and approval. Deployed in the *register-ak* pod.
3. **Trustee Integration**: Updates Trustee deployment with secrets and attestation keys for node verification. Part of the *operator* pod.
4. **Machine Controller**: Reconciles Machine custom resources representing individual nodes. Part of the *operator* pod
5. **Secret Management**: Generates and manages LUKS. encryption keys and attestation key secrets. Part of the *operator* pod.
6. **Attestation Server**: [Trustee](https://github.com/confidential-containers/trustee) deployment handle the attestation request
7. **Reference Values calculation**: calculate the reference values provided by the approved images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

Suggested change
1. **Registration Server**: HTTP service that handles initial machine registration and Ignition configuration delivery. Deployes in the *registration server*.
2. **AttestationKey Controller**: Manages attestation key registration and approval. Deployed in the *register-ak* pod.
3. **Trustee Integration**: Updates Trustee deployment with secrets and attestation keys for node verification. Part of the *operator* pod.
4. **Machine Controller**: Reconciles Machine custom resources representing individual nodes. Part of the *operator* pod
5. **Secret Management**: Generates and manages LUKS. encryption keys and attestation key secrets. Part of the *operator* pod.
6. **Attestation Server**: [Trustee](https://github.com/confidential-containers/trustee) deployment handle the attestation request
7. **Reference Values calculation**: calculate the reference values provided by the approved images.
1. **Registration Server**: HTTP service that handles initial machine registration and Ignition configuration delivery. Deploys in the *registration server* pod.
2. **AttestationKey Controller**: Manages attestation key registration and approval. Deployed in the *attestation key registration server* pod.
3. **Trustee Integration**: Updates Trustee deployment with secrets and attestation keys for node verification. Part of the *operator* pod.
4. **Machine Controller**: Reconciles Machine custom resources representing individual nodes. Part of the *operator* pod.
5. **Secret Management**: Generates and manages LUKS encryption keys and attestation key secrets. Part of the *operator* pod.
6. **Attestation Server**: [Trustee](https://github.com/confidential-containers/trustee) deployment handle the attestation request
7. **Reference Values calculation**: Calculates the reference values provided by the approved images.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment is although called register-ak :). Maybe not the best name, I agree

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I think then they should all be named by pod, and speaking even more technically, it's attestation-key-register

Signed-off-by: Alice Frosi <afrosi@redhat.com>
@alicefr alicefr force-pushed the design-architecture branch from a9d9c67 to 0f5b181 Compare January 30, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants