-
Notifications
You must be signed in to change notification settings - Fork 9
Enable trusted_execution_cluster tests on OpenShift #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable trusted_execution_cluster tests on OpenShift #159
Conversation
531e94d to
eeb7555
Compare
This commit updates the test utils to support running trusted execution cluster tests on the OpenShift platform. To execute these tests on OpenShift, the following environment variables must be configured: - REGISTRY: The repository location of the container image. - TAG: The specific tag of the container image. - CLUSTER_URL: The API URL of the target cluster. - PLATFORM: Set this to 'openshift'. Signed-off-by: Roy Kaufman <rkaufman@redhat.com>
eeb7555 to
8e5ef07
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iroykaufman, Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@iroykaufman: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Not sure if it make sense to create an abstraction and trait here for when we are in kubernetes and when we are in openshift, or it is a bit overkilled. @Jakob-Naucke WDYT? |
Hmm. I'm a bit in favour because I'm already checking against platform two extra times in #170. |
Yeah, I think we are going to have more places like this in the future where we need to distinguish the platform. @iroykaufman do you mind refactoring the code? |
This commit updates the test utils to support running trusted execution cluster tests on the OpenShift platform.
To execute these tests on OpenShift, the following environment variables must be configured:
openshift.example:
RUST_LOG=info REGISTRY=quay.io PLATFORM=openshift CLUSTER_URL=<SECRET_URL> cargo test --test trusted_execution_cluster -- --no-capture