Skip to content

Conversation

@yairpod
Copy link

@yairpod yairpod commented Jan 29, 2026

Updating all Fedroa container images to version 43. Also updating rust version to 1.92

Updating all Fedroa container images to version 43.
Also updating rust version to 1.92

Signed-off-by: Yair Podemsky <ypodemsk@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2026

Hi @yairpod. Thanks for your PR.

I'm waiting for a trusted-execution-clusters member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alicefr
Copy link
Contributor

alicefr commented Jan 29, 2026

The PR looks good to me. But I more wondering if we should tag the buildroot with the fedora version instead of latest. It isn't clear on which fedora is built from and when 44 becomes the new latest, then we might accidentally switch to 44.

@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alicefr, yairpod

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2026

@yairpod: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-lifecycle-verify 742c0a1 link true /test operator-lifecycle-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@Jakob-Naucke Jakob-Naucke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as per the lint result, you'll also need to update the toolchain in .github. See also #116.

But I more wondering if we should tag the buildroot with the fedora version instead of latest.

@alicefr yes, :fedora is whatever buildroot updates to, and incidentally, we've been building on an F43 (not F42) buildroot that's slowly been running out of date. We could move buildroot to tagging the version too (and then, ideally, having dependabot update to latest not rawhide)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants