-
Notifications
You must be signed in to change notification settings - Fork 9
Update Container images to fedora 43 #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updating all Fedroa container images to version 43. Also updating rust version to 1.92 Signed-off-by: Yair Podemsky <ypodemsk@redhat.com>
|
Hi @yairpod. Thanks for your PR. I'm waiting for a trusted-execution-clusters member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The PR looks good to me. But I more wondering if we should tag the buildroot with the fedora version instead of latest. It isn't clear on which fedora is built from and when 44 becomes the new latest, then we might accidentally switch to 44. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, yairpod The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@yairpod: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Jakob-Naucke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but as per the lint result, you'll also need to update the toolchain in .github. See also #116.
But I more wondering if we should tag the buildroot with the fedora version instead of latest.
@alicefr yes, :fedora is whatever buildroot updates to, and incidentally, we've been building on an F43 (not F42) buildroot that's slowly been running out of date. We could move buildroot to tagging the version too (and then, ideally, having dependabot update to latest not rawhide)
Updating all Fedroa container images to version 43. Also updating rust version to 1.92