Skip to content

find native implementation from object prototype chain #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svalaskevicius wants to merge 1 commit into
base: master
Choose a base branch
from
Open

find native implementation from object prototype chain #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/vu8/Class.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,18 +114,34 @@ class ClassSingleton
template <class P>
static inline ValueHandle Forward(const v8::Arguments& args) {
v8::HandleScope scope;
v8::Local<v8::Object> self = args.Holder();

// this will kill without zero-overhead exception handling
try {
return scope.Close(ForwardReturn<P>(
static_cast<T *>(self->GetPointerFromInternalField(0)), args));
return scope.Close(
ForwardReturn<P>(
retrieveNativeObjectPtr(args.Holder()),
args
)
);
}
catch (std::runtime_error const& e) {
return Throw(e.what());
}
}

static inline T* retrieveNativeObjectPtr(v8::Local<v8::Value> value)
{
while (value->IsObject()) {
v8::Local<v8::Object> obj = value->ToObject();
T * native = static_cast<T *>(obj->GetPointerFromInternalField(0));
if (native) {
return native;
}
value = obj->GetPrototype();
}
return NULL;
}

static inline void MadeWeak(v8::Persistent<v8::Value> object,
void *parameter)
{
Expand Down