Master fixing #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us to test the function with unit tests. Signed-off-by: frajasalo <github@frajasalo.de>
This unit test triggers an error which occurs if the value for the seconds reaches 24 hours. This bug is similar issue #1 which original described a bug with the value of 3601 seconds. Signed-off-by: frajasalo <github@frajasalo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I separated the timestring function (into support.cpp) and wrote a unit test for it. If the separation is not Ok I will find another way for testing it.
Bug described in issue #1 is fixed by you in a previous commit but a new one come out: values of 24 hours or more issues the same problem.