Skip to content

Support new mobile number 179 for CN #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MonkeyLucas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support new mobile number 179 for CN #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions phonenumberutil_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,11 @@ func Test_IsValidNumber(t *testing.T) {
err: nil,
isValid: true,
region: "CN",
}, {
Copy link

@jiyamathias jiyamathias Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you did here was to add a new number set to the testcases and not necessarily add Support new number 179 for CN. I assume the issue you are attempting to fix is the invalid number error you get when you provide a CN number that starts with 179 right?

input: "+8617910517228",
err: nil,
isValid: true,
region: "CN",
},
}

Expand Down