-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/metric proxy bindings #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually used, or do you use the prediction server already implemented in FTIO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ftio/api/metric_proxy/proxy_zmq.py is a zmq server to specifically support what metric proxy needs, so it is used. It's probably possible to change proxy_zmq.py to rely on some of the already implemented functions instead of using a complete custom method but that would require refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is fine. We can keep it this way. I would just suggest that you document these points alongside some instructions (e.g., call tree?) in a seperate file for FTIO as described here: https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing. Also maybe you can add some test cases so that we do not break these functionalites in the future with newer commits (https://github.com/tuda-parallel/FTIO/blob/feature/pattern_change_detection/docs/students_contribute.md#-module-documentation-and-licensing)
Added command to start ZMQ server, which listens for requests from Metric Proxy. Includes variable port, argument usage from the Proxy, MessagePack serialization/deserialization and uses either parallel execution for multiple metrics or normal execution for a single metric.
This is a complementary feature to https://github.com/A-Tarraf/proxy_v2/tree/feature_ftio and is related to Issue #13 .